Fix failing rubyspecs for String#unpack #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, odd one: the build fails, but all I can see is an error whilst building jruby-launcher which doesn’t sound related? |
|
Yeah, I think the build's failure has nothing to do with your changes. I'll review what you have here and make sure it's working ok before pushing. |
|
Looks ok here! |
headius
added a commit
that referenced
this pull request
Apr 29, 2013
Fix failing rubyspecs for String#unpack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the 22 failing specs for
String#unpack, and addresses http://jira.codehaus.org/browse/JRUBY-5656.